Add self.filename as a VideoFileClip attribute
#405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docstring on lines 39-40 state that `VideoFileClip` has an object `self.filename`. This is not currently correct, as only its `reader` has that attribute. This commit adds `filename` as an attribute of the actual clip as well. Current usage: `my_clip.reader.filename` Proposed usage: `my_clip.filename Also added line 45 to explain that a `VideoFileClip` does actually have more than 2 useful attributes.
|
Thanks ! |
mbeacom
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstring on lines 39-40 state that
VideoFileCliphas an objectself.filename. This is not currently correct, as only itsreaderhas that attribute. This PR addsfilenameas an attribute of the actual clip as well.Current usage:
my_clip.reader.filename`` Proposed usage:my_clip.filenameAlso added line 45 to explain that a
VideoFileClipdoes actually have more than 2 useful attributes.