Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several YouTube examples in Gallery page are unable to load. #600

Closed
Julian-O opened this issue Jul 1, 2017 · 12 comments
Closed

Several YouTube examples in Gallery page are unable to load. #600

Julian-O opened this issue Jul 1, 2017 · 12 comments
Labels
documentation Related to documentation in official project docs or individual docstrings.

Comments

@Julian-O
Copy link
Contributor

Julian-O commented Jul 1, 2017

  • The embedded video for Cup Song Covers Mix reports "An error occurred. Please try again later." with a playback id. The underlying YouTube video is fine.

  • Similarly, the videos for:

    • The (old) MoviePy reel video.
    • Piano rolls transcription to sheet music
    • Videogrep
  • Soccer cuts won't show because embedding has been banned. It can only be displayed in YouTube.

@keikoro
Copy link
Collaborator

keikoro commented Jul 1, 2017

@Julian-O The video you linked results in a 404 on my end.

@Zulko
Copy link
Owner

Zulko commented Jul 1, 2017

@Julian-O Thanks for the report. 4 videos are down for me too. Maybe there was a change in the youtube API ? Btw the address of the video you linked is:

https://www.youtube.com/watch?v=rIehsqqYFEM

@Julian-O
Copy link
Contributor Author

Julian-O commented Jul 1, 2017

Whoops. Sorry for broken link. The point I was hoping to convey was that the first few videos themselves remain up and working on YouTube. They haven't been taken down - it seems an API change is the most likely cause.

Julian-O added a commit to Julian-O/moviepy that referenced this issue Jul 2, 2017
* Used YouTube to get new iframes HTML.
* Replaced embedded image with link for private video.
tburrows13 pushed a commit that referenced this issue Jul 8, 2017
#600: Several YouTube examples in Gallery page won't load.
@keikoro
Copy link
Collaborator

keikoro commented Nov 25, 2017

Looks like this can be closed? (Changes merged in #606?)

@keikoro keikoro added the documentation Related to documentation in official project docs or individual docstrings. label Nov 25, 2017
@krishraghuram
Copy link

Has the bug resurfaced?

screenshot from 2018-01-21 10-22-37

@keikoro
Copy link
Collaborator

keikoro commented Jan 21, 2018

Hey @krishraghuram, maybe not all examples were fixed - did you check if this one in particular was included in the linked PR or earlier ones dealing with the same issue?

@Julian-O Julian-O reopened this Jan 22, 2018
@Julian-O
Copy link
Contributor Author

The merge does not seem to have been completely carried out.

For example, the changes to gallery.rst I proposed in #600 has this embedding for the Cup Song:

<iframe width="560" height="315" src="https://www.youtube.com/embed/rIehsqqYFEM" frameborder="0" allowfullscreen></iframe>

The pull request in #606 has the same text.

The master copy has the same text.

However, the file being served by github.io - i.e. the official web-site for documentation - still contains the old text.

This issue should not be closed until the official documentation is pointing to Master.

@kerstin: To answer your November 2017 question: No, it should remain open. To answer your recent suggestion: No, it wasn't one or two examples that were missed. The whole page needs updating.

@krishraghuram: No, the bug hasn't "resurfaced", but was never completely solved.

@keikoro
Copy link
Collaborator

keikoro commented Jan 22, 2018

@Julian-O Thanks for the update! I don't have time to look at this in detail right now, but I'm guessing it might have to do with the online documentation living in the gh-pages branch?

@Julian-O
Copy link
Contributor Author

@kerstin: I think you have put your finger on the problem. I've created PR #700 to address.

@keikoro
Copy link
Collaborator

keikoro commented Jan 22, 2018

@Julian-O IIRC the documentation has to be generated and (only?) the resulting HTML has to be pushed to the gh_pages branch (the HTML and not the source is what makes up the online docs).

I'm not entirely sure though if... we found a way at some point to make the docs auto-generate?

(I only know that you can configure GitLab so you only need to push source files to the branch for online docs and it'll generate the HTML for you. On GitHub, I think this only works for Jekyll-based docs or blogs?)

@Julian-O
Copy link
Contributor Author

@kerstin: Oh... I assumed without any knowledge that the GitHub.io page was somehow configured to take its source from some particular subdirectory of the branch and generate its own cache. I guess my PR #700 is meaningless then.

@tburrows13
Copy link
Collaborator

All fixed as of Feb 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation in official project docs or individual docstrings.
Projects
None yet
Development

No branches or pull requests

5 participants