-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Travis support for Python 3.7 and 3.8 #1018
Conversation
@tburrows13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require updating the travis dist from trusty
to xenial
Cheers, that does agree with my research. I don't know if that will break the other checks though. There's definitely ways around it anyway. |
It seems that it can't find an ffmpeg version for Xenial |
# Conflicts: # .travis.yml
I think that this is ready to merge now (after squashing first!). There's a fairly large special case for Python 2 (which is basically the previous contents of .travis.yml) that can be removed when we stop testing against Python 2. I've been trying a few different things with pytest, tox and Travis (#1083, #1085 and https://github.com/tburrows13/moviepy/tree/travis-matrix), none of which have really worked. In summary, getting a unified test process between local and CI testing is complicated and not worth it. Travis does now have support for Windows, but it is not yet possible to run ffmpeg on it yet because the server version is missing multimedia dlls. Some further things to explore would be testing macOS and pypy on Travis. From my recent endeavours, it seems like they will both be possible. The hardest parts are usually getting ffmpeg and ImageMagick to work. |
I'd appreciate a quick review of this before merging. |
No description provided.