Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis support for Python 3.7 and 3.8 #1018

Merged
merged 35 commits into from
Mar 9, 2020
Merged

Conversation

tburrows13
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Oct 1, 2019

Coverage Status

Coverage increased (+0.02%) to 64.983% when pulling e3bd401 on tburrows13:py37 into a16a107 on Zulko:master.

@mbeacom
Copy link
Collaborator

mbeacom commented Oct 1, 2019

@tburrows13 3.7 on Travis requires dist: xenial

mbeacom
mbeacom previously requested changes Oct 1, 2019
Copy link
Collaborator

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require updating the travis dist from trusty to xenial

@tburrows13
Copy link
Collaborator Author

Cheers, that does agree with my research. I don't know if that will break the other checks though. There's definitely ways around it anyway.

@tburrows13
Copy link
Collaborator Author

It seems that it can't find an ffmpeg version for Xenial

@tburrows13 tburrows13 dismissed mbeacom’s stale review February 23, 2020 04:29

Suggestion completed

@tburrows13 tburrows13 changed the title Add Travis support for Python 3.7 Add Travis support for Python 3.7 and 3.8 Feb 23, 2020
@tburrows13
Copy link
Collaborator Author

I think that this is ready to merge now (after squashing first!). There's a fairly large special case for Python 2 (which is basically the previous contents of .travis.yml) that can be removed when we stop testing against Python 2.

I've been trying a few different things with pytest, tox and Travis (#1083, #1085 and https://github.com/tburrows13/moviepy/tree/travis-matrix), none of which have really worked. In summary, getting a unified test process between local and CI testing is complicated and not worth it. Travis does now have support for Windows, but it is not yet possible to run ffmpeg on it yet because the server version is missing multimedia dlls.

Some further things to explore would be testing macOS and pypy on Travis. From my recent endeavours, it seems like they will both be possible. The hardest parts are usually getting ffmpeg and ImageMagick to work.

@tburrows13
Copy link
Collaborator Author

I'd appreciate a quick review of this before merging.

@tburrows13 tburrows13 added this to the Release v1.0.2 milestone Feb 23, 2020
@tburrows13 tburrows13 added tests Related to individual tests in the test suite or running the test suite. tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo. labels Feb 24, 2020
@tburrows13 tburrows13 merged commit 11f0d8d into Zulko:master Mar 9, 2020
@tburrows13 tburrows13 deleted the py37 branch April 26, 2020 22:32
@keikoro keikoro added LGTM Passed inspection by maintainers. and removed mergable labels Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Passed inspection by maintainers. tests Related to individual tests in the test suite or running the test suite. tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants