Added encoding optional parameter to subtitle file loading feature #1043
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had many issues with file encodings because I deal with special characters in my SRT files and this was a necessary step for me to solve them for good. It's an easy and straightforward change, but really handy if you need to specify your encoding when loading the SRT file.
Before you could only do this:
sub = SubtitlesClip("subtitles.srt", generator)
Now you can also specify your encoding if you want or need to:
sub = SubtitlesClip("subtitles.srt", generator, encoding='utf-8')
The
encoding
parameter is optional.Special thanks to @Darkade for helping me figure this out.