Add support for path-like objects with a decorator #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
tburrows13
added
the
feature
mgaitan
reviewed
Apr 9, 2020
mgaitan
reviewed
Apr 9, 2020
4 tasks
|
Any objections to merging this? |
|
go ahead.
…On Sat, Apr 18, 2020 at 8:43 AM Tom Burrows ***@***.***> wrote:
Any objections to merging this?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1137 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR7EBZK2NJ6RMEYTK7SU23RNGG6VANCNFSM4MCSNYLA>
.
--
mgaitan.github.io
textosypretextos.com.ar
|
tburrows13
added a commit
to gpantelis/moviepy
that referenced
this pull request
Apr 19, 2020
Implement path support by use of `convert_path_to_string` decorator
Closed
tburrows13
added a commit
that referenced
this pull request
May 6, 2020
* New functionality New method that stabilaze a video * make the code PEP8 compatible * Align with PEP-257 * Small corrections * PEP 8 compatible * Rename stabilazed to stabilized * Tidy code * Rewrite docs * Fix logger in tools.subprocess_call Broken since bfad5ea * Add basic unit test * Add support for path-like objects with a decorator (#1137) Implement path support by use of `convert_path_to_string` decorator * Add support for path-like objects * Apply black * Add changelog entry * Update ffmpeg_tools.py * Apply black Co-authored-by: Tom Burrows <tomburrows13@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #924, and heavily based off of it, so thank you to @PaperBag42 for doing the bulk of the work. The main difference is that I've implemented converting the path objects to a string by using a decorator
convert_path_to_string()instead of callingos.fspath()each time.tests/black -t py36