Ability to set pixel format for video or image files #1237
Conversation
Add ability to set pixel format for the following functions/methods and classes: - ``write_videofile()`` from ``VideoClip`` class. - ``FFMPEG_VideoReader`` class. - ``ffmpeg_read_image`` function from 'ffmpeg_reader.py' - ``FFMPEG_VideoWriter`` class from 'ffmpeg_writer.py' - ``ffmpeg_write_video`` function from 'ffmpeg_writer.py' - ``ffmpeg_writer_image`` function from 'ffmpeg_writer.py' - ``VideoFileClip`` class.
tburrows13
added
the
feature
|
Thank you so much for this, it looks great! I've made a couple of tiny changes (I could have left the suggestions as a comment, but they were so trivial I just went ahead and did them myself in the web editor). I wouldn't worry about tests for this PR. I don't really have a clue where to begin writing tests for When you're happy with it, I'll merge it into master and it will be available in the next v2.0 dev release. |
tburrows13
changed the title
Add the functionality to change the pixel format when creating a gif. But this new feature is only available when ffmpeg is used. This new feature change ``write_gif`` from 'VideoClip.py'. As well ``write_gif_with_tempfiles`` and ``write_gif`` from 'gif_writers.py'
|
I added the feature to add a pixel format when creating a gif. But is limited to only do that when the program you use is 'ffmpeg'. I also added a test for it. Feel free to make any suggestion or comments :) |
Add the ability to set the pixel format when create a gif using tempfiles.
|
I think I have nothing more to add to this PR. So I think we can close it if there is nothing more to contribute this time. |
Closes #1070
Basically just add an
pix_fmtfor the some classes, functions and methods to allow different pixels formats instead of the defaults 'rgba' and 'rgb24', but these two are kept ifpix_fmtis not given:writer_videofile()fromVideoClipclass.FFMPEG_VideoReaderclass.ffmpeg_read_imagefunction fromffmpeg_reader.py.FFMPEG_VideoWriterclass fromffmpeg_writer.py.ffmpeg_writer_videofunction fromffmpeg_writer.py.ffmpeg_writer_imagefunction fromffmpeg_writer.py.VideoFileClipclass.I haven't created the tests for these changes because I am a little lost on where to do it. I notice the class
FFMPEG_VideoWriterdoesn't have a test.VideoFileClipstores an instance for that class but in his unit test only checks one variable from it and because of that I don't know if I should create a test about my change there. A little orientation about this would be very helpful.I also want to implement this for
.write_gif(), and because of this and what I previously mentioned I would label this PR as a work in progress.