Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to terminate the process that has ended #1296

Merged
merged 4 commits into from
Jan 13, 2021
Merged

Conversation

luyanger1799
Copy link
Contributor

check if the process exists before using teminate() to stop the process.

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@coveralls
Copy link

coveralls commented Aug 12, 2020

Coverage Status

Coverage decreased (-0.01%) to 67.532% when pulling 1c555ab on luyanger1799:master into 79b2c1d on Zulko:master.

@tburrows13
Copy link
Collaborator

Hello, thanks for the PR. I'm not quite sure why this is necessary? Does calling terminate crash if the process has already terminated?

@tburrows13 tburrows13 added the bug-fix For PRs and issues solving bugs. label Oct 4, 2020
@tburrows13 tburrows13 mentioned this pull request Oct 6, 2020
5 tasks
Copy link
Collaborator

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing this legit 👍 Thank you for the improvement @luyanger1799 🙏

If the process has been stopped by another program or the user want to interact directly with the project, this becomes useful.

Does calling terminate crash if the process has already terminated?

Nope

@tburrows13
Copy link
Collaborator

I don't really understand, so I'll go with your judgement on this. Presumably the same thing should be added to https://github.com/Zulko/moviepy/blob/master/moviepy/video/io/ffmpeg_reader.py#L228 then?

You can commit directly to this PR if you need to, so that it is done as one PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PRs and issues solving bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants