New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect behaviour from BitmapClip when fps != 1 #1333

Merged

tburrows13 merged 2 commits into Zulko:master from tburrows13:fix-BitmapClip

Oct 6, 2020

Collaborator

tburrows13 commented Oct 6, 2020

Closes #1326.
Added tests 1 and 3 fail without this PR. Test 1 (fps < 1) would crash and test 3 (fps > 1) would return the wrong results.

I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
I have formatted my code using black -t py36

tburrows13 added 2 commits

October 6, 2020 14:53


          Fix BitmapClip.iter_frames() when fps != 1 (closes Zulko#1326)

84ca734


          Update CHANGELOG.md

114a0ff

tburrows13 added the bug-fix label

coveralls commented Oct 6, 2020 •

edited

Loading

Coverage increased (+0.3%) to 67.861% when pulling 114a0ff on tburrows13:fix-BitmapClip into 0e4bf6d on Zulko:master.

tburrows13 merged commit 873530e into Zulko:master

tburrows13 deleted the fix-BitmapClip branch

October 6, 2020 14:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment