Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove audio_loop afx #1451

Merged
merged 4 commits into from
Jan 16, 2021
Merged

Remove audio_loop afx #1451

merged 4 commits into from
Jan 16, 2021

Conversation

tburrows13
Copy link
Collaborator

audio_loop is unneeded because loop can be applied to audio clips the same as video clips.

@tburrows13 tburrows13 added the breaking-change Must not merge without proper approval. Requires full documentation (own section) in the changelog. label Jan 15, 2021
@coveralls
Copy link

coveralls commented Jan 15, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 66.201% when pulling 1a1fd82 on tburrows13:remove-audio-loop into 20309f1 on Zulko:master.

mondeja
mondeja reviewed Jan 15, 2021
View reviewed changes
Copy link
Collaborator

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file and this line from docs/ref/audiofx.rst should be removed.

@tburrows13 tburrows13 merged commit 727cbca into Zulko:master Jan 16, 2021
@tburrows13 tburrows13 deleted the remove-audio-loop branch January 16, 2021 00:22
@mondeja

This comment has been minimized.

Sign in to view
@tburrows13

This comment has been minimized.

Sign in to view
@tburrows13 tburrows13 mentioned this pull request Jan 16, 2021
Open
tburrows13 added a commit to tburrows13/moviepy that referenced this pull request Jan 19, 2021
@tburrows13
Remove audio_loop afx (Zulko#1451)
c3e088e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondeja mondeja mondeja left review comments

Assignees
No one assigned
Labels
breaking-change Must not merge without proper approval. Requires full documentation (own section) in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tburrows13 @coveralls @mondeja