Fix 'fps' not defined for 'CompositeAudioClip' at initialization #1462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1457
CompositeAudioClip
to make it more readable, fix minor issues and use generators building attributes.concatenate_audioclips
in corcondance.fps
not defined inCompositeAudioClip
initialization if created directly or usingCompositeVideoClip
.AudioClip
tests.The
fps
of theCompositeAudioClip
will be the maximumfps
attribute of their clips, if any has the attribute setted. If an user uses differentfps
for their clips, no error neither warning is raised so is their responsibility to handle this inconsistency, because could be the desired behavior in some experimental compositions.tests/
black -t py36