Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'fps' not defined for 'CompositeAudioClip' at initialization #1462

Merged
merged 10 commits into from
Jan 19, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 16, 2021

Closes #1457

  • Refactor initialization of CompositeAudioClip to make it more readable, fix minor issues and use generators building attributes.
  • Refactor concatenate_audioclips in corcondance.
  • Fix error of fps not defined in CompositeAudioClip initialization if created directly or using CompositeVideoClip.
  • Fix some AudioClip tests.

The fps of the CompositeAudioClip will be the maximum fps attribute of their clips, if any has the attribute setted. If an user uses different fps for their clips, no error neither warning is raised so is their responsibility to handle this inconsistency, because could be the desired behavior in some experimental compositions.

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@mondeja mondeja added audio Related to AudioClip, or handling of audio in general. bug-fix For PRs and issues solving bugs. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. labels Jan 16, 2021
@coveralls
Copy link

coveralls commented Jan 16, 2021

Coverage Status

Coverage increased (+0.02%) to 65.906% when pulling 7a63f1e on mondeja:rewrite-CompositeAudioClip into 7183eaa on Zulko:master.

@mondeja mondeja changed the title Fix 'fps' not being defined for 'CompositeAudioClip' if not created using 'concatenate_audioclips' Fix 'fps' not defined for 'CompositeAudioClip' if not created using 'concatenate_audioclips' Jan 17, 2021
@mondeja mondeja changed the title Fix 'fps' not defined for 'CompositeAudioClip' if not created using 'concatenate_audioclips' Fix 'fps' not defined for 'CompositeAudioClip' at initialization Jan 18, 2021
@mondeja mondeja merged commit ce7b129 into Zulko:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio Related to AudioClip, or handling of audio in general. bug-fix For PRs and issues solving bugs. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompositeAudioClip fails on preview
2 participants