fixing region parameter on freeze_region #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was having trouble with getting good results from the freeze_region function when I specified a region. Specifying an outer_region gave exactly the expected response, but specifying a region positioned the region at 0,0 regardless of the values of x1 and y1. I get the correct results when I rewrote and tested the function by setting the position last instead of first (lines 38 - 40). Issue here: Zulko#146 (comment)
Zulko
added a commit
that referenced
this pull request
Mar 25, 2015
fixing region parameter on freeze_region
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble with getting good results from the freeze_region function when I specified a region. Specifying an outer_region gave exactly the expected response, but specifying a region positioned the region at 0,0 regardless of the values of x1 and y1. I get the correct results when I rewrote and tested the function by setting the position last instead of first (lines 38 - 40). Issue here