Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for retrieve clip frames number using 'clip.n_frames' #1471

Merged
merged 5 commits into from
Jan 20, 2021
Merged

Add support for retrieve clip frames number using 'clip.n_frames' #1471

merged 5 commits into from
Jan 20, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 19, 2021

Closes #1058

@mondeja mondeja added the feature New addition to the API i.e. a new class, method or parameter. label Jan 19, 2021
@mondeja mondeja changed the title Add support for retrieve the number of frames of a clip using 'clip.nframes' Add support for retrieve clip frames number using 'clip.nframes' Jan 19, 2021
@coveralls
Copy link

coveralls commented Jan 19, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 66.012% when pulling 36f5c17 on mondeja:nframes-property into 22e207e on Zulko:master.

@tburrows13
Copy link
Collaborator

I prefer n_frames to nframes (and I'll likely change similar ones like nchannels to that in the future). Other than that its good.

@mondeja mondeja changed the title Add support for retrieve clip frames number using 'clip.nframes' Add support for retrieve clip frames number using 'clip.n_frames' Jan 19, 2021
@mondeja mondeja marked this pull request as draft January 19, 2021 22:39
@mondeja mondeja mentioned this pull request Jan 19, 2021
Merged
5 tasks
@mondeja mondeja marked this pull request as ready for review January 19, 2021 22:58
@mondeja mondeja merged commit a378771 into Zulko:master Jan 20, 2021
@mondeja mondeja deleted the nframes-property branch June 1, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tburrows13 tburrows13 Awaiting requested review from tburrows13

Assignees
No one assigned
Labels
feature New addition to the API i.e. a new class, method or parameter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

how to get the frames number of the whole video ?
3 participants
@mondeja @coveralls @tburrows13