poor error message from ffmpeg_reader.py #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per [http://stackoverflow.com/questions/11497234/typeerrorexceptions-must-be-old-style-classes-or-derived-from-baseexception-no](http://stackoverflow.com/questions/11497234/typeerrorexceptions-must-be-old-style-classes-or-derived-from-baseexception-no), as of python 2.6, you can't raise just a string. If this particular error is triggered, you just get a message {TypeError} exceptions must be old-style classes or derived from BaseException, not unicode The nearby exceptions are IOErrors, so I made this one an IOError as well. Now it shows the real exception, instead of the cryptic message above.
|
For what it's worth, I'm using python 2.7.6 on 64-bit Linux. |
Zulko
added a commit
that referenced
this pull request
Apr 15, 2015
poor error message from ffmpeg_reader.py
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per http://stackoverflow.com/questions/11497234/typeerrorexceptions-must-be-old-style-classes-or-derived-from-baseexception-no, as of python 2.6, you can't raise just a string. If this particular error is triggered, you just get a message
The nearby exceptions are IOErrors, so I made this one an IOError as well. Now it shows the real exception, instead of the cryptic message above.