Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #1682 ( audio cutout ) #1705

Closed
wants to merge 2 commits into from

Conversation

selentium
Copy link

@selentium selentium commented Dec 30, 2021

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly explained unusual or unexpected code in the comments around it

@keikoro
Copy link
Collaborator

keikoro commented Dec 30, 2021

@selentium You can link issues by using # followed by the issue number – doing so makes things easier for everyone, but particularly maintainers in the case of PRs. Also, if you remove the spaces from the square brackets which you ticked off (by putting an x between them) in the PR template, they'll show up as ticked boxes.

@keikoro keikoro linked an issue Dec 30, 2021 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Dec 31, 2021

Coverage Status

Coverage increased (+0.2%) to 84.941% when pulling 13cf50a on selentium:fix_audio_cutout_issue_1682 into 8eaf3f0 on Zulko:master.

@selentium selentium changed the title Fix for issue 1682 ( audio cutout ) Fix for issue #1682 ( audio cutout ) Jan 2, 2022
@keikoro
Copy link
Collaborator

keikoro commented Mar 13, 2022

The file which originally caused the Code format check to fail has just been fixed. It'd make sense to rebase master so all the automated checks can run over this PR again.

@selentium selentium closed this Apr 17, 2022
@selentium selentium deleted the fix_audio_cutout_issue_1682 branch April 17, 2022 10:45
@keikoro keikoro mentioned this pull request Apr 26, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants