Relax Numpy constraints #1732
Merged
Relax Numpy constraints #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keikoro
added
lib-misc
|
Only tangentially related note: the files which caused the Code format check to fail have meanwhile been fixed. |
|
Sounds good I have fetched upstream so if those were the only failing tests then this PR should work now. |
|
Hi @tburrows13! I'm not sure why you pinned Numpy to |
I think just because 1.19 was the current version when I created that PR and I didn't want to assume compatibility with unreleased versions. If they've been tested then I'm fine with increasing/removing the restriction. |
tburrows13
approved these changes
Mar 25, 2022
mondeja
approved these changes
Mar 26, 2022
bzczb
pushed a commit
to bzczb/moviepy
that referenced
this pull request
Jan 27, 2023
* bump numpy to 1.20 * relax numpy constraints (cherry picked from commit 7e3e8bb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a different repo we have been running into problems caused by moviepy's numpy version constraints. I suspected that these constraints were unnecessary so I cloned the repo and tested under different versions of numpy.
I have found that versions 1.17.3, 1.18.0, 1.20.0, 1.21.5, and 1.22.3 (latest version) all result in passing tests.
I also tested 1.17.0 which fails to install. Nevertheless it seems like all numpy versions going forward from 1.17.3 are compatible with moviepy. I would recommend that the
<=1.20.0constraint be removed and to allow numpy versions going forward to prevent against unnecessary version conflicts for other packages.Another idea would be to add
<2.0.0for a potentially backwards incompatible major version jump, or a more conservative<1.23.0for minor revision changes. Patches are very safe to assume will continue to work correctly.Thanks!
PS I tested locally on a mac, I'll be checking to make sure CI here also works as expected for this change.