Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ValueError if invalid arguments passed to TextClip #1842

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Raise ValueError if invalid arguments passed to TextClip #1842

merged 2 commits into from
Oct 10, 2022

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Oct 10, 2022

At least one of filename or text arguments of TextClip are required. Now raises ValueError if no filename and text arguments are provided.

@mondeja mondeja added the enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. label Oct 10, 2022
@mondeja mondeja mentioned this pull request Oct 10, 2022
Closed
@coveralls
Copy link

coveralls commented Oct 10, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.9%) to 82.993% when pulling b01c707 on filename-or-text-required-TextClip into 97870c9 on master.

@mondeja mondeja changed the title Raise error if invalid arguments passed to TextClip Raise ValueError if invalid arguments passed to TextClip Oct 10, 2022
@mondeja mondeja merged commit 858bb81 into master Oct 10, 2022
@mondeja mondeja deleted the filename-or-text-required-TextClip branch October 10, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mondeja @coveralls