Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version parsing in setup.py #2010

Closed
wants to merge 1 commit into from
Closed

Fix version parsing in setup.py #2010

wants to merge 1 commit into from

Conversation

vanmatten
Copy link

The last character of the version is cut out by [:-1] in Path("moviepy/version.py").read_text().strip().split('"')[1][:-1].
Eg: 2.0.0.dev2 become 2.0.0.dev, which Python build reads as 2.0.0.dev0.

In fact Path("moviepy/version.py").read_text().strip().split('"') gives ['__version__ = ', '2.0.0.dev2', ''] so removing the last character isn't needed.

The last character of the version is cut out by `[:-1]`.
Eg: `2.0.0.dev2` become `2.0.0.dev`, which Python build converts in `2.0.0.dev0`.
@coveralls
Copy link

coveralls commented Jul 19, 2023

Coverage Status

coverage: 81.904%. remained the same when pulling fde9ce4 on vanmatten:patch-1 into bc8d1a8 on Zulko:master.

@vanmatten vanmatten closed this Oct 25, 2023
@vanmatten vanmatten deleted the patch-1 branch October 25, 2023 14:32
@keikoro
Copy link
Collaborator

keikoro commented Feb 10, 2024

I'm not sure why this was closed/deleted, I can only see that tests failed (not why), did this not solve the problem after all?

@vanmatten
Copy link
Author

vanmatten commented Feb 11, 2024

I'm not sure why this was closed/deleted, I can only see that tests failed (not why), did this not solve the problem after all?

Tests failed as in the main branch when I created the commit and I don't know why.
This commit do exactly what I have written in the title, I closed it because the pull request of v2.0 fix this issue as others.

If you think that reopening this pull request is usefull, i'll do it.

@keikoro
Copy link
Collaborator

keikoro commented Feb 11, 2024

Thanks for the info.

I closed it because the pull request of v2.0 fix this issue as others

If another PR fixes the issue anway, there is indeed no need to reopen this one. Thanks, in any case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants