Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small recipe (mirroring a video) #243

Merged
1 commit merged into from
Feb 15, 2017
Merged

small recipe (mirroring a video) #243

1 commit merged into from
Feb 15, 2017

Conversation

zodman
Copy link
Contributor

@zodman zodman commented Dec 23, 2015

No description provided.

@mbeacom mbeacom added the documentation Related to documentation in official project docs or individual docstrings. label Feb 15, 2017
@ghost ghost merged commit 75bc1af into Zulko:master Feb 15, 2017
@ghost
Copy link

ghost commented Feb 15, 2017

Thanks for the contribution!.. Sorry it took so long to merge in..

@Zulko
Copy link
Owner

Zulko commented Feb 15, 2017

Sorry I never commented this one before, but I object to it. The code is for command-line (Id like to avoid that in the docs), the use or variables is not ideal (clip gets overwritten), and there is a syntax error on the last line.

@ghost
Copy link

ghost commented Feb 15, 2017

okay.. since it was just documentation, and the code looked correct (I didn't see the syntax error), I saw no harm in merging it. I'll start waiting for comments before merging in the future.

@Zulko
Copy link
Owner

Zulko commented Feb 15, 2017

There was indeed no harm, but I am a bit picky, and since I had 3 objections for just 5 lines of code, I'd prefer not to merge this one.

@keikoro
Copy link
Collaborator

keikoro commented Feb 15, 2017

I suggested e-mail, but could we otherwise maybe create one (new) thread (issue) here to lay out some ground rules or workflow ideas? (I'm just thinking that might save everyone some time in the long run.)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation in official project docs or individual docstrings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants