fixes #248 issue with VideoFileClip() not reading all frames

[aldilaff]

No description provided.

[MicahRamirez]

Why -1 ?

[aldilaff]

The issue I was facing is that moviepy was not reading the data of large gifs correctly. Looking at the code, the line I changed used to read the first element of a list. I found out that for large gifs, the data is being read incrementally and added to the list. So the element with the "full" length of large gifs was actually the last element. -1 is just the last element of a list.

[ghost]

@aldilaff can you change this so that it reads something like:

if is_Gif:
   line = [l for l in lines if keyword in l][-1]
else:
  line = [l for l in lines if keyword in l][0]

[ghost]

@aldilaff I'll give you a few more days to respond, if not, I'll create another pull request that makes the necessary changes I have suggested, and will close this PR.

[coveralls]

Changes Unknown when pulling 69e51c1 on aldilaff:master into ** on Zulko:master**.

[aldilaff]

@Earney My apologies for the delay. Updated.

[tburrows13]

Maybe there should be a comment in there explaining why, or at least linking to this PR?

[ghost]

@achalddave Gloin1313 is probably right.. Can you add the following comment to your submission?

#for large GIFS the "full" length is presented as the last element in the output.

Thanks!

[mbeacom]

Instead of writing out the line = twice, we could probably replace L264-L267 with something like:

index = -1 if is_GIF else 0
line = [l for l in lines if keyword in l][index]

or even:

line = [l for l in lines if keyword in l][-1 if is_GIF else 0]

Granted, there is a lot we could refactor in there to get more DRY, but you get the point!

Thanks for the PR, btw!

[ghost]

@achalddave thanks for updating this.. We will try to merge it ASAP..

[achalddave]

Hmm, I assume I'm being mentioned here due to a typo? I think you want @aldilaff :)

[mbeacom]

LGTM

[coveralls]

Changes Unknown when pulling f156c95 on aldilaff:master into ** on Zulko:master**.