Incorporated optional progress_bar flag for writing video to file #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tburrows13
approved these changes
Feb 15, 2017
mbeacom
added
the
enhancement
This was referenced Mar 2, 2017
|
I'll test this, and merge if successful |
|
Sounds great, thanks!
…On Thu, Mar 2, 2017 at 10:55 AM Gloin1313 ***@***.***> wrote:
I'll test this, and merge if successful
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#380 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEatMk0AxY1Oq0tQwHtDqRvC6fMDNxijks5rhuZWgaJpZM4LcROu>
.
|
|
@wingillis It works... kind of... It correctly removes the progress bar for writing the video, but not for the audio progress bar before the video. Do you want to add this, or shall I add it as a separate PR? I'm happy to merge this as is if we can sort out the audio separately. EDIT: I've found where it calls tqdm for audio, I'll do this myself. Thanks for your contribution! |
tburrows13
pushed a commit
that referenced
this pull request
Mar 6, 2017
Adds `progress_bar` option to `write_audiofile()` to complement #380
tburrows13
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential flag addition to suppress the progress bar workaround.
Very useful for batch computing systems where this output clutters the results.