Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #313, make concatenate_videoclips python 3 compatible. #410

Merged
merged 3 commits into from Feb 15, 2017
Merged

fix issue #313, make concatenate_videoclips python 3 compatible. #410

merged 3 commits into from Feb 15, 2017

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2017

No description provided.

@mbeacom mbeacom self-requested a review February 15, 2017 13:53
Copy link
Collaborator

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ultimately, I think we should move the py2/py3 check to a new compat.py to handle py2/py3 compatibility. For now, this works! Thanks for your contributions @Earney.

@mbeacom mbeacom added bug Issues that report (apparent) bugs. python-version Compatibility issues, behaviour changes,... between different Python versions. labels Feb 15, 2017
@mbeacom mbeacom added this to the Release v0.2.2.13 milestone Feb 15, 2017
@mbeacom mbeacom merged commit 3137695 into Zulko:master Feb 15, 2017
This was referenced Feb 15, 2017
@ghost
Copy link
Author

ghost commented Feb 15, 2017

@mbeacom .. I was starting to think the same thing.. I'll work on creating a compat.py file with contents:

import sys
PY3 = sys.version_info.major >=3

then I can look at replacing all the updates I've made with

from compat import PY3

where do you recommend that we place the compat.py file ? maybe moviepy/compat.py, right next to config.py ?

@ghost
Copy link
Author

ghost commented Feb 15, 2017

Can this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that report (apparent) bugs. python-version Compatibility issues, behaviour changes,... between different Python versions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants