Issue 145 #415
Closed
Issue 145 #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull from zulko/moviepy
|
I'd recommend putting the variable 'transition' into the error message somewhere so the user can know what he/she put in wrong (helpful if the code calling it is heavily automatic). Also, is the a more standard moviepy error message format? ie begins with something like 'Moviepy Error:' |
|
I've modified the pull so that the function name is retrieved at runtime so that the error message is more descriptive. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was suggested in issue #145, to output some type of error if the method argument was not valid (ie, 'chain' or 'compose'). The modification allow for an exception to be raised.