-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify setup.py handling #531
Conversation
this is a bit beyond my current skill level, but it looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me too. I just hope it doesn't complicate installation via other means than pip, but it doesn't seem so.
The goal of this PR is to implement changes to
setup.py
to include:optional
to install all optional dependencies via pip.test
to install all test dependencies via pip.docs
to install all documentation dependencies via pip.setup.py
command, to enablepython setup.py test
to install testing dependencies and run testing suite.setup.py
command, to enablepython setup.py build_doc
to build HTML documentation.Simple additions to documentation:
Misc modifications:
makehtml.sh
to make it executable../docs/build/
and simply ignore thebuild
directory.Steps to test
python setup.py test
successfully installs themoviepy
test dependencies and runs the test suite.pip install -e .[docs]; python setup.py build_docs -E; open docs/build/html/index.html
successfully installs themoviepy
doc dependencies and builds the documentation.pip install -e .[optional]
successfully installs all of themoviepy
dependencies.pip install -e .[test]
successfully installs all of test relatedmoviepy
dependencies.pip install -e .
successfully installsmoviepy
base.