General tests cleanup #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbeacom
added
cleanup
tests-needed
mbeacom
commented
Apr 17, 2017
|
@mbeacom I'll look into fixing the path issues. |
|
@mbeacom see moviepy/editor.py line 53 to see why we are getting resize errors. It seems that editor.py does more than just import a few files. For the test files that are producing the resize errors I'm going to put back the from editor import *. |
ghost
requested review from
|
this PR looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to cleanup some of the
tests/*handling, sprinkle some pep-8, simplify some imports, etc. This isn't meant to be a complete cleanup and refactor of tests, but a step towards instituting pep-8/pep-256/257 standards (line limits/syntax, docstrings, etc) while making it a little more DRY.