Removed Hz from audio_fps match in ffmpeg_parse_infos #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage is only decreasing because https://github.com/Zulko/moviepy/pull/665/files#diff-a49583100a493b6fe1c05b48824e4a3cL389 is no longer executed on any of the test media files. |
|
Thank you very much for this! I'll merge it right away |
|
Haha, just found this PR again. I've investigated, and you're definitely right, this is a bug. However, it doesn't appear that this |
|
Yes that may be true. Seems like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cuts the ' Hz' off of the regex match when trying to find the fps info of an audio stream.
Previously, this was always setting
result['audio_fps']to'unknown'because the casting to an integer would fail.