Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8 test to find syntax errors, undefined names #705

Merged
merged 2 commits into from
Feb 13, 2018
Merged

flake8 test to find syntax errors, undefined names #705

merged 2 commits into from
Feb 13, 2018

Conversation

cclauss
Copy link

@cclauss cclauss commented Feb 4, 2018

No description provided.

@tburrows13 tburrows13 added the tests Related to individual tests in the test suite or running the test suite. label Feb 12, 2018
@tburrows13
Copy link
Collaborator

Looks good to me. I'm just merging the PRs you suggested, then I'll rerun the build here.

@tburrows13
Copy link
Collaborator

After rerunning it, there are still errors: 5 in Python 3.6 and 2 in Python 2. 3 of the Python 3.6 ones are because they are Python 2 builtins (cmp, execfile and unicode). Not sure what can be done about this...

The 2 that are common to py2 and py3 are a reference to newfile in Clip.py and time_to_string in subtitles.py. The newfile one appears to still be legitimate due to the @outplace decorator (I have no idea how decorators work, so I may be wrong). The time_to_string appears to be a genuine bug that I'll have a look at later.

So, is there a way of suppressing the py2/3 errors, because obviously we can't merge this as it stands right now. It is a useful tool that I think would be good to have.

@cclauss
Copy link
Author

cclauss commented Feb 12, 2018

Give me 24 hours and I will submit more PRs.

@tburrows13
Copy link
Collaborator

Great, thank you! No rush though

We can reverse this later but at least we can get the tests in place but allow the to fail without breaking the build.
@coveralls
Copy link

coveralls commented Feb 12, 2018

Coverage Status

Coverage increased (+0.01%) to 57.211% when pulling c023a73 on cclauss:patch-1 into a90d4ab on Zulko:master.

@cclauss
Copy link
Author

cclauss commented Feb 13, 2018

Please review this one because it would be good to get it merged in.

@tburrows13
Copy link
Collaborator

Yep, this is really useful! Thanks

@tburrows13 tburrows13 merged commit 9ae9de9 into Zulko:master Feb 13, 2018
@cclauss cclauss deleted the patch-1 branch February 13, 2018 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants