Progress bar optional for GIF creation #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me. Waiting a bit for one more opinion and we can merge. |
|
Hi, I'm creating a new version for you now, which will ship to PyPI shortly. |
|
Moviepy version 0.2.3.5 is now live with your PR in. Enjoy! |
|
❤️ thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-API-breaking change which makes the display of a progress bar optional when making gifs.
Moviepy has been used to create gifs for tensorboard to visualise deep learning, with this package. However, the terminal is usually used to keep track of training progress - the unwanted display of progress bars interrupts this display, hence this pull request to allow for them to be hidden.