FFmpeg Writer: handle redirected logs when checking for errors #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously we were looking for `'foo' in None` resulting in a TypeError (Zulko#877) * Now, if an `IOError` occurs when running FFmpeg to write video clips, **but** there is no output returned, assume we are redirected, and give the user a helpful message about where to look for errors (i.e. in the logs), instead of throwing a secondary `TypeError`. * Add test for this case. Fixes Zulko#877.
For some reason Pytest on Python 2 is not catching this, even though they are aliases in the code, and Python 3.4 - 3.6 all do...
Overdrivr
reviewed
Mar 28, 2019
Overdrivr
added
the
review-needed
|
@Overdrivr Sorry - I never saw the feedback. I've updated as suggested... |
|
@declension this is ok for me and I would like to merge it. Could you fix the conflicts? |
|
maybe we should rebase it against |
|
That's the conflicts fixed (just through the web editor). If the tests pass, feel free to merge. |
I can't say I love its newlines, but hey it's here now...
|
@tburrows13 @mgaitan fixed the remaining PR bits up now, please merge whenever. |
tburrows13
removed
the
review-needed
|
Great, thanks for fixing it up. It will be released with v2.0. |
5 tasks
keikoro
added
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'foo' in Noneresulting in a TypeError (FFMPEG VideoWriter throws TypeError on error when logged. #877)IOErroroccurs when running FFmpeg to write video clips, but there is no output returned, assume we are redirected, and give the user a helpful message about where to look for errors (i.e. in the logs), instead of throwing a secondaryTypeError.Fixes #877.