Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #926 #927

Merged
merged 3 commits into from
Mar 27, 2019
Merged

Fix for #926 #927

merged 3 commits into from
Mar 27, 2019

Conversation

Overdrivr
Copy link
Collaborator

@Overdrivr Overdrivr commented Mar 19, 2019

Closes #926

  • If this is a bugfix, I have provided code that clearly demonstrates the problem and that works when used with this PR
  • I have added a test to the test suite, if necessary
  • I have properly documented new or changed features in the documention, or the docstrings
  • I have properly documented unusual changes to the code in the comments around it
  • I have made note of any breaking/backwards incompatible changes

@bertwagner
Copy link

Hi @Overdrivr ,
I also have this same problem and I was able to find a fix for my test case: bertwagner@d5fc73a#diff-a49583100a493b6fe1c05b48824e4a3c

I ran it on your demo file and it seemed to work correctly. Do you want to test it out for yourself?

If it works, feel free to add it to your fix and merge it in since you already have started this thread. Otherwise let me know and I can submit a PR, thanks!

@Overdrivr
Copy link
Collaborator Author

@bertwagner I came up to the same exact solution, nice :) I wanted to see the CI fail on Windows platform without the fix, but since you confirmed the issue that's perfect I'll push the fix. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ffmpeg_parse_infos silently hangs on Windows when MP4 file contains enough metadata
2 participants