Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows user to pass additional parameters to ffmpeg when writing audio clips #94

Merged
merged 2 commits into from Dec 1, 2014

Conversation

jdelman
Copy link
Contributor

@jdelman jdelman commented Dec 1, 2014

A couple of small modifications to allow an additional parameter for write_audiofile. If ffmpeg_params is specified, it is added to the command.

@Zulko
Copy link
Owner

Zulko commented Dec 1, 2014

Thanks, that looks good ! Another user made the same for video clips but we forgot to do it for audio too.
I noticed that you left a "print cmd" line 72 in ffmpeg_audiowriter.py
, this is unwanted and will break Python 3, can you remove it before I merge ?

@jdelman
Copy link
Contributor Author

jdelman commented Dec 1, 2014

Fixed. Thanks!

Zulko added a commit that referenced this pull request Dec 1, 2014
Allows user to pass additional parameters to ffmpeg when writing audio clips
@Zulko Zulko merged commit e8b8a78 into Zulko:master Dec 1, 2014
@Zulko
Copy link
Owner

Zulko commented Dec 1, 2014

I didn't test it completely, but it seems all right. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants