Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that the temporary audio file exists #958

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

ybenitezf
Copy link
Contributor

@ybenitezf ybenitezf commented May 14, 2019

I'm using Moviepy in one of my projects and this problem about a temporary file that does not exist when calling VideoClip.write_videofile is popping up in our CI jobs.

This fix simply does the same thing as in TextClip testing that the tmp file exist before calling os.remove

@tburrows13 tburrows13 added the LGTM Passed inspection by maintainers. label Feb 23, 2020
@tburrows13 tburrows13 added this to the Release v1.0.2 milestone Feb 23, 2020
@tburrows13 tburrows13 added the bug-fix For PRs and issues solving bugs. label Mar 9, 2020
@tburrows13 tburrows13 merged commit d467ad9 into Zulko:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PRs and issues solving bugs. LGTM Passed inspection by maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants