Save debug log even when no SCSI requests are coming in #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally we wait for the STATUS phase to be able to save log file without disturbing SCSI processing. But this can cause the very last log messages not be saved to file. This commit changes behavior only when debug log is enabled. Log will be saved after 2 seconds when no new SCSI requests are coming. Shouldn't affect functional behavior, but to limit any performance impacts it is limited to debug mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we wait for the STATUS phase to be able to save log file without disturbing SCSI processing. But this can cause the very last log messages not be saved to file.
This commit changes behavior only when debug log is enabled. Log will be saved after 2 seconds when no new SCSI requests are coming. Shouldn't affect functional behavior, but to limit any performance impacts it is limited to debug mode.