Add platform support for CD-ROM eject buttons #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log messages got printed but the eject did not apply because of accidental copy of the image_config_t structure. Modified so that compiler will detect this mistake in future.
Previously when multiple images have been configured, the next image has been automatically inserted after ejection. Now with eject button support, some users may want to reinsert only after pressing the button again. This config option allows that. Default behavior remains as before. Also improved log messages of ejection button behavior.
Previously when switching from BIN/CUE image to ISO image, the cue sheet would be mistakenly applied to the ISO image as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #217 by @saybur, this adds platform implementations for GD32 and RP2040 models.
Also fixed two bugs found in testing:
Pinouts are documented here:
https://github.com/ZuluSCSI/ZuluSCSI-firmware/blob/8fb7380b5206ba28c3eacbf9cd4547c7406be484/README.md#physical-eject-button-for-cdrom