CD-ROM: volume control and mode changes #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idea is to allow dynamic mode pages that call into other parts of the program and limit the need for further customization of the SCSI2SD library.
These are reserved for CD devices in MMC-1. Using sg_modes on Linux, 0x03 is parsed as a Mount Rainer rewritable page and 0x04 is unparsed.
In addition to trying to fix vendor-specific mode pages that won't be understood, this works around a problem on modern Linux: with block descriptors present in MODE SENSE, changing volume via mmc_io_cdrom_volume() in cdrom.c appears to send block descriptor information following the 0x0E page update.
This appears to match the behavior expected from old drives, even though it does not appear within the specifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes to support CD-ROM volume control from software. There are three main proposals:
Any corrections or suggestions are welcome!