Add the ability to delay boot #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to delay booting in milliseconds before and/or after the first time SCSI interface is initialized. These settings are InitPreDelay and InitPostDelay in the "zuluscsi.ini" file. This is to fix an issue with the RP2040 boards not working with an MPC3000. Thus a preset has been added for the device name MPC3000 and can be set by using the System="MPC3000" in the "zuluscsi.ini" file. The InitPreDelay is set to 500 milliseconds for the preset. It should be noted that the InitPreDelay delays the first blink of the board turning on and InitPostDelay hold the LED on.
|
@PetteriAimonen could you do a quick code review. I'm not sure if the InitPostDelay would have any practical use as it would initialize the SCSI interface and then just hang for the delay amount. |
|
Code looks ok to merge. The effect of pre and post delay is pretty much the same, because in either case ZuluSCSI won't have any effect on the SCSI bus before the scsi polling starts. |
|
Tested directly on a MPC3000 here, works both with "System" and "InitPreDelay", the MPC works with the RP2040 now just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to delay booting in milliseconds before and/or after the first time SCSI interface is initialized.
These settings are InitPreDelay and InitPostDelay in the "zuluscsi.ini" file.
This is to fix an issue with the RP2040 boards not working with an MPC3000. Thus a preset has been added for the device name MPC3000 and can be set by using the System="MPC3000" in the "zuluscsi.ini" file. The InitPreDelay is set to 500 milliseconds for the preset.
It should be noted that the InitPreDelay delays the first blink of the board turning on and InitPostDelay hold the LED on.