Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Feat/refactor page view #163

Merged
merged 8 commits into from
Jul 23, 2020
Merged

Conversation

carolinegoncalveszup
Copy link
Contributor

@carolinegoncalveszup carolinegoncalveszup commented Jul 21, 2020

Closes #149

- What I did
Refactor page view according to the new contract. As we are not going to allow break changes for this version, we are keeping compatibility so the previous version should keep working (but a warning should be shown) and the new version should also work.

- How I did it
Create page indicator component and associate it as a default component, change page view interface to handle new contract and allow context to control the actual page.

- How to verify it
The playground project in /#/cloud/f5d7548ac6984460a068c67e84628de7/deprecatedPageView.json?platform=angular has an example of the new page view and the old page view, both should be working

- Description for the changelog

Refactor page view

Tiagoperes
Tiagoperes previously approved these changes Jul 23, 2020
rafamsilva
rafamsilva previously approved these changes Jul 23, 2020
@github-actions
Copy link

Code coverage

Filename Statements Branches Functions Lines
src/codegen/utils/formatting.ts 57.14% 100% 25% 66.67%
src/codegen/utils/handle-user-default-components.ts 0% 100% 0% 0%
src/index.ts 0% 100% 100% 0%
src/codegen/utils/metadata.ts 0% 0% 0% 0%
src/codegen/errors.ts 0% 100% 0% 0%
src/codegen/boilerplate/beagle-components.module.ts 0% 0% 0% 0%
src/codegen/utils/template-builder.ts 0% 0% 0% 0%
src/codegen/boilerplate/beagle.module.ts 0% 0% 0% 0%
src/codegen/compiled/beagle.module/index.ts 0% 100% 0% 0%
src/codegen/compiled/beagle.module/template.ts 0% 100% 0% 0%
src/codegen/compiled/beagle.module/module.ts 0% 0% 0% 0%
src/codegen/compiled/beagle.module/component.ts 0% 0% 0% 0%
src/codegen/compiled/beagle.module/commentary.ts 0% 100% 0% 0%
src/codegen/compiled/beagle.module/imports.ts 0% 0% 0% 0%
src/cli/index.ts 0% 0% 0% 0%
src/cli/utils/styledLogger.ts 0% 0% 0% 0%
src/cli/utils/userInput.ts 0% 0% 0% 0%
src/cli/utils/filesystem.ts 0% 0% 0% 0%
src/cli/utils/object.ts 0% 0% 0% 0%
src/cli/utils/git.ts 0% 0% 0% 0%
src/cli/utils/packages.ts 0% 0% 0% 0%
src/cli/operations/index.ts 0% 100% 0% 0%
src/cli/operations/view-engine/config.ts 0% 0% 0% 0%
src/cli/operations/view-engine/index.ts 0% 0% 0% 0%
src/cli/operations/help.ts 0% 0% 0% 0%
src/cli/operations/view-engine/process.ts 0% 0% 0% 0%
src/cli/operations/init/index.ts 0% 0% 0% 0%
src/cli/operations/init/boilerplate.ts 0% 0% 0% 0%
src/cli/operations/init/configuration.ts 0% 100% 0% 0%
src/cli/operations/init/ivy.ts 0% 0% 0% 0%
src/cli/operations/init/questions.ts 0% 0% 0% 0%
src/cli/operations/init/view-engine.ts 0% 0% 0% 0%
src/cli/errors.ts 0% 0% 0% 0%
src/errors.ts 0% 100% 0% 0%
src/components/beagle-error/beagle-error.component.ts 0% 100% 100% 0%
src/components/index.ts 0% 100% 100% 0%
src/components/beagle-modal/beagle-modal.component.ts 0% 0% 0% 0%
src/components/beagle-simple-form/beagle-simple-form.component.ts 0% 0% 0% 0%
src/components/beagle-page-view/beagle-page-view.component.ts 0% 0% 0% 0%
src/components/beagle-text/beagle-text.component.ts 0% 0% 0% 0%
src/components/services/tabs.service.ts 0% 100% 0% 0%
src/components/beagle-page-indicator/beagle-page-indicator.component.ts 0% 0% 0% 0%
src/components/beagle-webview/beagle-webview.component.ts 0% 0% 0% 0%
src/components/beagle-tab-view/beagle-tab-view.component.ts 0% 0% 0% 0%
src/components/beagle-loading/beagle-loading.component.ts 0% 100% 100% 0%
src/components/beagle-lazy/beagle-lazy.component.ts 0% 100% 0% 0%
src/components/beagle-markdown/beagle-markdown.component.ts 0% 0% 0% 0%
src/components/beagle-tab-bar/beagle-tab-bar.component.ts 0% 0% 0% 0%
src/components/beagle-button/beagle-button.component.ts 0% 0% 0% 0%
src/components/beagle-input/beagle-input.component.ts 0% 0% 0% 0%
src/components/beagle-text-area/beagle-text-area.component.ts 0% 0% 0% 0%
src/components/beagle-tab-item/beagle-tab-item.component.ts 0% 0% 0% 0%
src/components/beagle-image/beagle-image.component.ts 0% 0% 0% 0%
src/components/module.ts 0% 100% 100% 0%
src/components/beagle-touchable/beagle-touchable.component.ts 0% 0% 0% 0%
src/components/beagle-future-list-view/beagle-list-view.component.ts 0% 0% 0% 0%
src/components/beagle-list-view/beagle-list-view.component.ts 0% 100% 100% 0%
src/components/schemas/button.ts 0% 100% 100% 0%
src/components/beagle-container/beagle-container.component.ts 0% 0% 0% 0%
src/constants.ts 0% 100% 100% 0%
src/runtime/utils/promise.ts 0% 100% 0% 0%
src/runtime/utils/beagle-map-keys-config.ts 0% 100% 0% 0%
src/runtime/BeagleComponent.ts 0% 100% 100% 0%
src/runtime/beagle-context/module.ts 0% 100% 100% 0%
src/runtime/beagle-context/directive.ts 0% 0% 0% 0%
src/runtime/errors.ts 0% 100% 0% 0%
src/runtime/AbstractBeagleRemoteView.ts 0% 0% 0% 0%
src/runtime/BeagleProvider.service.ts 0% 0% 0% 0%
src/decorator.ts 0% 100% 0% 0%

@carolinegoncalveszup carolinegoncalveszup merged commit e28643d into master Jul 23, 2020
@carolinegoncalveszup carolinegoncalveszup deleted the feat/refactor-page-view branch July 23, 2020 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refatorar PageView usando a feature de contexto
3 participants