This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinegoncalveszup
requested review from
leonardosantiagozup,
rafamsilva,
raphaelspimenta,
tarcisiogc and
Tiagoperes
as code owners
July 21, 2020 21:35
3 tasks
Tiagoperes
previously approved these changes
Jul 23, 2020
rafamsilva
previously approved these changes
Jul 23, 2020
carolinegoncalveszup
dismissed stale reviews from rafamsilva and Tiagoperes
via
July 23, 2020 17:27
39a759a
➿ Code coverage
|
rafamsilva
approved these changes
Jul 23, 2020
Tiagoperes
approved these changes
Jul 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149
- What I did
Refactor page view according to the new contract. As we are not going to allow break changes for this version, we are keeping compatibility so the previous version should keep working (but a warning should be shown) and the new version should also work.
- How I did it
Create page indicator component and associate it as a default component, change page view interface to handle new contract and allow context to control the actual page.
- How to verify it
The playground project in
/#/cloud/f5d7548ac6984460a068c67e84628de7/deprecatedPageView.json?platform=angular
has an example of the new page view and the old page view, both should be working- Description for the changelog
Refactor page view