This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Create tabBar component #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinegoncalveszup
requested review from
leonardosantiagozup,
rafamsilva,
raphaelspimenta,
tarcisiogc and
Tiagoperes
as code owners
|
➿ Code coverage
|
3 tasks
Tiagoperes
approved these changes
Jul 23, 2020
rafamsilva
approved these changes
Jul 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Create new tabBar component which should be used instead of tabView for the new version. As we are not going to allow break changes for this version, we are keeping the tabView but indicating that the component is deprecated.
- How I did it
Create tabBar component and associate it as a default component
- How to verify it
The playground project in
/#/cloud/2d0c7b6557c544479853a3c9ab6113bd/tabBarRefactor?platform=react-webshould render correctly tabBar component- Description for the changelog
Create tabBar