This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Add show arrow and fix context behavior #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinegoncalveszup
requested review from
leonardosantiagozup,
rafamsilva,
raphaelspimenta,
tarcisiogc and
Tiagoperes
as code owners
3 tasks
rafamsilva
approved these changes
Jul 23, 2020
Tiagoperes
approved these changes
Jul 23, 2020
|
➿ Code coverage
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
As pageview will be used to simulate a tabview behavior, the arrows can't be always shown. Therefore, we added an optional prop
showArrowthat will be used to hide the arrows to support the cases where the pageview is together with the tabBar- How I did it
Add optional prop in interface and component
- How to verify it
Playground examples. Both, tabbar and pageview should be render correctly.
- Description for the changelog
Add show arrow prop