Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix user group permission and creates a modal for user group removal #1001

Merged
merged 49 commits into from
May 11, 2021

Conversation

Leandroqo
Copy link
Contributor

@Leandroqo Leandroqo commented Mar 16, 2021

Issue Description

It shows status 403 when a maintainer removes a user group that it belongs to.

Solution

  • creates a modal that asks the user about the removal of a user group.

Captura de Tela (363)

luanecavalcantizup and others added 4 commits March 16, 2021 09:05
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #1001 (0326cd3) into main (8fefe97) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1001      +/-   ##
============================================
- Coverage     76.71%   76.69%   -0.03%     
- Complexity     2164     2201      +37     
============================================
  Files          1303     1311       +8     
  Lines         18701    18487     -214     
  Branches       1707     1697      -10     
============================================
- Hits          14347    14178     -169     
+ Misses         3844     3800      -44     
+ Partials        510      509       -1     
Flag Coverage Δ Complexity Δ
gate ? ?
ui 79.83% <100.00%> (+0.14%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/core/assets/themes/modal/trigger.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Card/Config/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Text/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
...edentials/Sections/UserGroup/__tests__/fixtures.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/index.tsx 69.56% <ø> (-2.44%) 0.00 <0.00> (ø)
ui/src/core/components/Modal/Trigger/index.tsx 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Modal/Trigger/styled.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Text/styled.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...Settings/Credentials/Sections/UserGroup/helpers.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
.../Settings/Credentials/Sections/UserGroup/index.tsx 97.29% <100.00%> (+32.59%) 0.00 <0.00> (ø)
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d701bd...0326cd3. Read the comment docs.

@luanecavalcantizup luanecavalcantizup changed the title Fix usergroup permission Fix user group permission Mar 17, 2021
luanecavalcantizup and others added 2 commits March 17, 2021 10:25
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
@luanecavalcantizup luanecavalcantizup added the bug Something isn't working label Mar 17, 2021
luanecavalcantizup and others added 18 commits March 17, 2021 14:28
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
bCatanant
bCatanant previously approved these changes Mar 23, 2021
@luanecavalcantizup luanecavalcantizup changed the title Fix user group permission Fix user group permission and creates a modal for user group removal Mar 23, 2021
ifdouglas
ifdouglas previously approved these changes Apr 5, 2021
luanecavalcantizup and others added 2 commits April 5, 2021 11:00
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@Leandroqo Leandroqo mentioned this pull request Apr 27, 2021
celiofilhozup and others added 4 commits April 28, 2021 15:22
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup
Copy link
Contributor

blocked by pr #1108

@luanecavalcantizup
Copy link
Contributor

waiting to be tested

@luanecavalcantizup luanecavalcantizup merged commit 7e6a40f into main May 11, 2021
@luanecavalcantizup luanecavalcantizup deleted the fix-usergroup-permission branch May 11, 2021 19:22
@fandrade-zup fandrade-zup restored the fix-usergroup-permission branch May 11, 2021 20:58
@barbararochazup barbararochazup deleted the fix-usergroup-permission branch January 12, 2022 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants