This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Fix user group permission and creates a modal for user group removal #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1001 +/- ##
============================================
- Coverage 76.71% 76.69% -0.03%
- Complexity 2164 2201 +37
============================================
Files 1303 1311 +8
Lines 18701 18487 -214
Branches 1707 1697 -10
============================================
- Hits 14347 14178 -169
+ Misses 3844 3800 -44
+ Partials 510 509 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
luanecavalcantizup
changed the title
Fix usergroup permission
Fix user group permission
Mar 17, 2021
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: Leandro Queiroz <leandroqueiroz92@gmail.com>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
… into fix-usergroup-permission
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
bCatanant
previously approved these changes
Mar 23, 2021
luanecavalcantizup
changed the title
Fix user group permission
Fix user group permission and creates a modal for user group removal
Mar 23, 2021
ifdouglas
previously approved these changes
Apr 5, 2021
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
luanecavalcantizup
dismissed stale reviews from ifdouglas and bCatanant
via
April 20, 2021 18:47
bdc128e
Merged
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
… into fix-usergroup-permission
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
blocked by pr #1108 |
waiting to be tested |
lucassaleszup
approved these changes
May 11, 2021
bCatanant
approved these changes
May 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
It shows status
403
when a maintainer removes a user group that it belongs to.Solution