Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix list metric prometheus error #1013

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Fix list metric prometheus error #1013

merged 2 commits into from
Apr 6, 2021

Conversation

icaroafonsozup
Copy link
Contributor

Issue Description

Sometimes the list of Prometheus metrics to use in a metric group could be empty.

Solution

Fixed error where start date parameter was after end date parameter at calling Prometheus API.

…t calling Prometheus API.

Signed-off-by: Icaro Gabriel Marques Afonso <icaro.afonso@zup.com.br>
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #1013 (a478dc8) into main (6d415f0) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1013      +/-   ##
============================================
- Coverage     77.70%   77.53%   -0.18%     
  Complexity     1978     1978              
============================================
  Files          1213     1234      +21     
  Lines         16799    17842    +1043     
  Branches       1566     1566              
============================================
+ Hits          13054    13833     +779     
- Misses         3271     3490     +219     
- Partials        474      519      +45     
Flag Coverage Δ Complexity Δ
compass 74.68% <ø> (?) 0.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
compass/internal/moove/mooveclient.go 72.22% <0.00%> (ø) 0.00% <0.00%> (?%)
compass/internal/metricsgroupaction/main.go 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
compass/internal/metric/metricexecution.go 66.66% <0.00%> (ø) 0.00% <0.00%> (?%)
compass/internal/plugin/main.go 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
compass/internal/metric/metric.go 80.64% <0.00%> (ø) 0.00% <0.00%> (?%)
compass/internal/metricsgroup/metricsgroup.go 71.08% <0.00%> (ø) 0.00% <0.00%> (?%)
compass/internal/moove/main.go 83.33% <0.00%> (ø) 0.00% <0.00%> (?%)
compass/internal/action/queries.go 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
compass/internal/plugin/plugin.go 71.79% <0.00%> (ø) 0.00% <0.00%> (?%)
.../internal/metricsgroupaction/metricsgroupaction.go 89.60% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d415f0...a478dc8. Read the comment docs.

@icaroafonsozup icaroafonsozup merged commit 65dea21 into main Apr 6, 2021
@icaroafonsozup icaroafonsozup deleted the metricsListEmpty branch April 6, 2021 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants