Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix showing username undefined in the initial screen #1016

Merged
merged 4 commits into from
Apr 8, 2021

Conversation

luanecavalcantizup
Copy link
Contributor

@luanecavalcantizup luanecavalcantizup commented Mar 24, 2021

Signed-off-by: luanecavalcantizup luane.cavalcanti@zup.com.br

Issue Description

In the initial screen, username is not showing, instead undefined is shown.

Solution

Get profile name from localstorage.

Screenshots:

image

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #1016 (f20eeae) into main (826ac3d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1016      +/-   ##
============================================
- Coverage     77.98%   77.96%   -0.03%     
  Complexity     2164     2164              
============================================
  Files          1242     1242              
  Lines         17346    17347       +1     
  Branches       1589     1589              
============================================
- Hits          13527    13524       -3     
- Misses         3339     3343       +4     
  Partials        480      480              
Flag Coverage Δ Complexity Δ
ui 80.66% <100.00%> (-0.05%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Workspaces/index.tsx 69.23% <100.00%> (-6.77%) 0.00 <0.00> (ø)
ui/src/core/utils/auth.ts 81.96% <0.00%> (-3.28%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826ac3d...f20eeae. Read the comment docs.

@luanecavalcantizup luanecavalcantizup added the bug Something isn't working label Mar 24, 2021
@luanecavalcantizup luanecavalcantizup self-assigned this Mar 24, 2021
@monicaribeiro monicaribeiro merged commit 30b8abe into main Apr 8, 2021
@monicaribeiro monicaribeiro deleted the fix-showing-undefined-username branch April 8, 2021 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants