Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Add max length validation to input fields #1024

Merged
merged 38 commits into from
Apr 28, 2021

Conversation

luanecavalcantizup
Copy link
Contributor

@luanecavalcantizup luanecavalcantizup commented Apr 6, 2021

Issue Description

Add max length validation to fields: component name and version name. The sum of them must not be greater than 63 characters.

Solution

  • Add max length validation for component name field, when creating a new component
  • Add max length validation for component name field, when creating a new module
  • Add max length validation for version name field, when creating a new release

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup self-assigned this Apr 6, 2021
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #1024 (daf75a5) into main (46c39d4) will increase coverage by 0.01%.
The diff coverage is 96.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1024      +/-   ##
============================================
+ Coverage     77.67%   77.69%   +0.01%     
+ Complexity     2172     2168       -4     
============================================
  Files          1256     1256              
  Lines         17593    17587       -6     
  Branches       1611     1616       +5     
============================================
- Hits          13666    13664       -2     
+ Misses         3444     3440       -4     
  Partials        483      483              
Flag Coverage Δ Complexity Δ
ui 79.95% <96.42%> (+0.06%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/core/components/ConnectionStatus/index.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Modules/Comparation/Form/index.tsx 93.18% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Circles/Release/Create/Module.tsx 90.00% <80.00%> (-1.90%) 0.00 <0.00> (ø)
ui/src/core/components/Form/Input/index.tsx 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Text/index.tsx 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
ui/src/modules/Circles/Release/Create/helpers.ts 76.00% <100.00%> (+6.76%) 0.00 <0.00> (ø)
ui/src/modules/Circles/Release/Create/index.tsx 72.22% <100.00%> (+5.55%) 0.00 <0.00> (ø)
...src/modules/Modules/Comparation/Form/Component.tsx 80.00% <100.00%> (ø) 0.00 <0.00> (ø)
...modules/Modules/Comparation/Form/ComponentForm.tsx 95.45% <100.00%> (+9.09%) 0.00 <0.00> (ø)
ui/src/modules/Modules/Comparation/Form/styled.ts 92.30% <100.00%> (+0.30%) 0.00 <0.00> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0712dd5...daf75a5. Read the comment docs.

luanecavalcantizup and others added 24 commits April 6, 2021 10:41
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
…charlescd into fix-add-validation-to-some-fields
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
luanecavalcantizup and others added 9 commits April 15, 2021 16:38
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup marked this pull request as ready for review April 16, 2021 17:24
Leandroqo
Leandroqo previously approved these changes Apr 20, 2021
bCatanant
bCatanant previously approved these changes Apr 20, 2021
Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup merged commit c57ea83 into main Apr 28, 2021
@luanecavalcantizup luanecavalcantizup deleted the fix-add-validation-to-some-fields branch April 28, 2021 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants