Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix matcher csv update #1029

Merged
merged 12 commits into from
Apr 30, 2021
Merged

Fix matcher csv update #1029

merged 12 commits into from
Apr 30, 2021

Conversation

thallesfreitaszup
Copy link
Contributor

Issue Description

Please include a summary of what should be implemented or which problem has been corrected. Please also include relevant motivation and context.

Solution

Please include a summary of the change and what has been implemented. Please also include relevant motivation and context. List all the dependencies required for this change.

Results

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

Request (if appropriate):

Url: POST {{url}}/hello/{{hello-code}}

Payload:

{
    "key" : "value"
}

Response:

Status: 200 OK

Payload:

{
    "key" :  "value"
}

Screenshots (if appropriate):

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
…tcher-csv-update

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label Apr 8, 2021
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #1029 (c68fcba) into main (c57ea83) will decrease coverage by 0.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1029      +/-   ##
============================================
- Coverage     77.69%   76.98%   -0.71%     
- Complexity     2168     2173       +5     
============================================
  Files          1256     1252       -4     
  Lines         17587    17679      +92     
  Branches       1616     1591      -25     
============================================
- Hits          13664    13610      -54     
- Misses         3440     3588     +148     
+ Partials        483      481       -2     
Flag Coverage Δ Complexity Δ
moove 75.25% <100.00%> (+0.05%) 1654.00 <3.00> (+5.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...charlescd/moove/application/KeyValueRuleService.kt 100.00% <100.00%> (ø) 5.00 <1.00> (+1.00)
...eployment/impl/DeploymentCallbackInteractorImpl.kt 100.00% <100.00%> (+2.12%) 29.00 <2.00> (+2.00)
ui/src/modules/Metrics/Deploys/CircleFilter.tsx 80.00% <0.00%> (-20.00%) 0.00% <0.00%> (ø%)
ui/src/modules/Circles/Release/Create/helpers.ts 69.23% <0.00%> (-6.77%) 0.00% <0.00%> (ø%)
ui/src/modules/Circles/Release/Create/index.tsx 66.66% <0.00%> (-5.56%) 0.00% <0.00%> (ø%)
ui/src/modules/Main/Sidebar/MenuItems/index.tsx 94.73% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
...cd/moove/application/user/response/UserResponse.kt 95.23% <0.00%> (-4.77%) 7.00% <0.00%> (-1.00%)
...rlescd/moove/application/CsvSegmentationService.kt 62.50% <0.00%> (-4.69%) 14.00% <0.00%> (-2.00%)
...i/deployments/controller/deployments.controller.ts 80.00% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
...ation/module/impl/UpdateComponentInteractorImpl.kt 90.00% <0.00%> (-3.34%) 7.00% <0.00%> (+2.00%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab4012b...c68fcba. Read the comment docs.

thallesfreitaszup and others added 4 commits April 9, 2021 10:51
Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
…rlescd into fix-matcher-csv-update

Signed-off-by: thalles freitas <thalles.freitas@zup.com.br>
@thallesfreitaszup thallesfreitaszup merged commit a6551b3 into main Apr 30, 2021
@thallesfreitaszup thallesfreitaszup deleted the fix-matcher-csv-update branch April 30, 2021 20:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module. TESTED QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants