Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Checking if subscription is null. #1036

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

monicaribeiro
Copy link
Contributor

No description provided.

Signed-off-by: Mônica Ribeiro <monicarib1@gmail.com>
@boring-cyborg boring-cyborg bot added the hermes label Apr 12, 2021
@monicaribeiro
Copy link
Contributor Author

monicaribeiro commented Apr 12, 2021

Developed by @barbararochazup

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #1036 (5ace2fa) into main (30b8abe) will decrease coverage by 0.95%.
The diff coverage is n/a.

❗ Current head 5ace2fa differs from pull request most recent head 2af43fc. Consider uploading reports for the commit 2af43fc to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1036      +/-   ##
============================================
- Coverage     77.96%   77.00%   -0.96%     
  Complexity     2164     2164              
============================================
  Files          1242     1250       +8     
  Lines         17347    17632     +285     
  Branches       1589     1589              
============================================
+ Hits          13524    13577      +53     
- Misses         3343     3575     +232     
  Partials        480      480              
Flag Coverage Δ Complexity Δ
hermes 18.59% <ø> (?) 0.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
hermes/internal/subscription/queries.go 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
hermes/internal/subscription/main.go 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
hermes/internal/notification/message/main.go 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...messageexecutionhistory/messageexecutionhistory.go 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
hermes/internal/subscription/subscription.go 25.45% <0.00%> (ø) 0.00% <0.00%> (?%)
...ernal/notification/messageexecutionhistory/main.go 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
hermes/internal/configuration/configuration.go 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
hermes/internal/notification/message/message.go 25.27% <0.00%> (ø) 0.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a06f8...2af43fc. Read the comment docs.

@monicaribeiro monicaribeiro merged commit a511461 into main Apr 13, 2021
@monicaribeiro monicaribeiro deleted the hotfix/hermes-subscription-error branch April 13, 2021 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants