Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

bug hunting: Fix menu item layout #1103

Merged
merged 3 commits into from
Apr 28, 2021
Merged

bug hunting: Fix menu item layout #1103

merged 3 commits into from
Apr 28, 2021

Conversation

luanecavalcantizup
Copy link
Contributor

Issue Description

If a menu item was long, when selecting an item bellow it, part of the word was covered.

Solution

Decrease size of box used to style menu items.

Screenshots (before):

image

Screenshots (after):

image

Signed-off-by: luanecavalcantizup <luane.cavalcanti@zup.com.br>
@luanecavalcantizup luanecavalcantizup changed the title Fix menu item layout bug hunting: Fix menu item layout Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #1103 (8b4bfdb) into system-token (c556b5b) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 8b4bfdb differs from pull request most recent head aa77698. Consider uploading reports for the commit aa77698 to get more accurate results
Impacted file tree graph

@@                Coverage Diff                 @@
##             system-token    #1103      +/-   ##
==================================================
+ Coverage           77.74%   77.87%   +0.12%     
  Complexity           2172     2172              
==================================================
  Files                1303     1313      +10     
  Lines               18134    18313     +179     
  Branches             1685     1685              
==================================================
+ Hits                14099    14261     +162     
- Misses               3535     3544       +9     
- Partials              500      508       +8     
Flag Coverage Δ Complexity Δ
gate 90.50% <ø> (?) 0.00 <ø> (?)
ui 79.90% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Main/Sidebar/styled.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
...use_case/system_token/create_system_token_input.go 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
gate/internal/domain/page.go 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...internal/use_case/system_token/get_system_token.go 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...ernal/use_case/system_token/create_system_token.go 94.59% <0.00%> (ø) 0.00% <0.00%> (?%)
...nal/use_case/authorization/authorize_user_token.go 81.25% <0.00%> (ø) 0.00% <0.00%> (?%)
...ernal/use_case/system_token/revoke_system_token.go 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...l/use_case/system_token/regenerate_system_token.go 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...l/use_case/authorization/authorize_system_token.go 76.31% <0.00%> (ø) 0.00% <0.00%> (?%)
...rnal/use_case/system_token/get_all_system_token.go 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c556b5b...aa77698. Read the comment docs.

@luanecavalcantizup luanecavalcantizup changed the base branch from main to system-token April 26, 2021 13:01
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label Apr 26, 2021
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label Apr 26, 2021
@luanecavalcantizup luanecavalcantizup self-assigned this Apr 26, 2021
Copy link
Contributor

@ifdouglas ifdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI ok

Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@luanecavalcantizup luanecavalcantizup requested review from Leandroqo and removed request for celiofilhozup April 27, 2021 18:52
@emiteze emiteze merged commit b0aeb52 into system-token Apr 28, 2021
@emiteze emiteze deleted the fix-menu-item branch April 28, 2021 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module. TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants