Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix git error #1126

Merged
merged 7 commits into from
Apr 30, 2021
Merged

Fix git error #1126

merged 7 commits into from
Apr 30, 2021

Conversation

thallesfreitaszup
Copy link
Contributor

@thallesfreitaszup thallesfreitaszup commented Apr 29, 2021

Issue Description

Sometimes requests of deploy failed because of a low limit of timeout on git requests.

Solution

Increase timeout and add a retry logic for the github request.Also improve error handling to not throw Cannot read property 'statusText' of undefined at /opt/darwin-deploy/dist/app/v2/core/integrations/github/github-repository.js:147:81

Results

Signed-off-by: thalles <thalles.freitas@zup.com.br>
Signed-off-by: thalles <thalles.freitas@zup.com.br>
Signed-off-by: thalles <thalles.freitas@zup.com.br>
@boring-cyborg boring-cyborg bot added the butler Improvements/additions/fixes for butler module. label Apr 29, 2021
@thallesfreitaszup thallesfreitaszup changed the base branch from main to butler-operator April 29, 2021 21:50
Signed-off-by: thalles <thalles.freitas@zup.com.br>
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1126 (276cfb3) into butler-operator (15e4430) will decrease coverage by 0.03%.
The diff coverage is 80.89%.

❗ Current head 276cfb3 differs from pull request most recent head 3c36cc6. Consider uploading reports for the commit 3c36cc6 to get more accurate results
Impacted file tree graph

@@                  Coverage Diff                  @@
##             butler-operator    #1126      +/-   ##
=====================================================
- Coverage              77.66%   77.62%   -0.04%     
- Complexity              2164     2177      +13     
=====================================================
  Files                   1259     1236      -23     
  Lines                  17552    17653     +101     
  Branches                1608     1629      +21     
=====================================================
+ Hits                   13631    13704      +73     
- Misses                  3436     3464      +28     
  Partials                 485      485              
Flag Coverage Δ Complexity Δ
butler 84.36% <87.17%> (-1.76%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...pi/deployments/controller/executions.controller.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
...operator/controller/deployments.hook.controller.ts 100.00% <ø> (ø) 0.00 <0.00> (?)
...on/request/CreateDeploymentConfigurationRequest.kt 100.00% <ø> (+100.00%) 6.00 <0.00> (+6.00)
...oove/infrastructure/service/DeployClientService.kt 97.56% <0.00%> (-2.44%) 7.00 <0.00> (ø)
...ure/service/client/response/HealthCheckResponse.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../src/core/assets/themes/circleDeploymentHistory.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Dropdown/Item/index.tsx 88.88% <ø> (-1.12%) 0.00 <0.00> (ø)
ui/src/core/components/Modal/FullScreen/styled.ts 44.44% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/components/Page/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/utils/date.ts 74.19% <ø> (+1.46%) 0.00 <0.00> (ø)
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5695ef...3c36cc6. Read the comment docs.

Signed-off-by: thalles <thalles.freitas@zup.com.br>
Signed-off-by: thalles <thalles.freitas@zup.com.br>
Signed-off-by: thalles <thalles.freitas@zup.com.br>
@thallesfreitaszup thallesfreitaszup merged commit b0b18a2 into butler-operator Apr 30, 2021
@thallesfreitaszup thallesfreitaszup deleted the fix-git-error branch April 30, 2021 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
butler Improvements/additions/fixes for butler module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants