This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thalles <thalles.freitas@zup.com.br>
Signed-off-by: thalles <thalles.freitas@zup.com.br>
Signed-off-by: thalles <thalles.freitas@zup.com.br>
boring-cyborg
bot
added
the
butler
Improvements/additions/fixes for butler module.
label
Apr 29, 2021
Codecov Report
@@ Coverage Diff @@
## butler-operator #1126 +/- ##
=====================================================
- Coverage 77.66% 77.62% -0.04%
- Complexity 2164 2177 +13
=====================================================
Files 1259 1236 -23
Lines 17552 17653 +101
Branches 1608 1629 +21
=====================================================
+ Hits 13631 13704 +73
- Misses 3436 3464 +28
Partials 485 485
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: thalles <thalles.freitas@zup.com.br>
Signed-off-by: thalles <thalles.freitas@zup.com.br>
thallesfreitaszup
force-pushed
the
fix-git-error
branch
from
April 30, 2021 13:37
276cfb3
to
3c36cc6
Compare
leandrorodrigueszup
approved these changes
Apr 30, 2021
lucasbfernandes
approved these changes
Apr 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
Sometimes requests of deploy failed because of a low limit of timeout on git requests.
Solution
Increase timeout and add a retry logic for the github request.Also improve error handling to not throw
Cannot read property 'statusText' of undefined at /opt/darwin-deploy/dist/app/v2/core/integrations/github/github-repository.js:147:81
Results