Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fixing permissions by workspace query #1130

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

emiteze
Copy link
Contributor

@emiteze emiteze commented Apr 30, 2021

Issue Description

Maintainer are receiving 403 to get a specific workspace.

Solution

Fixed the find permissions by workspace that queries for permissions on that workspace.

Signed-off-by: Mateus Cruz <emiteze@hotmail.com>
@emiteze emiteze changed the base branch from main to system-token April 30, 2021 14:33
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1130 (aedc3e6) into system-token (472647c) will decrease coverage by 0.12%.
The diff coverage is 77.77%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             system-token    #1130      +/-   ##
==================================================
- Coverage           77.87%   77.74%   -0.13%     
+ Complexity           2172     2154      -18     
==================================================
  Files                1313     1314       +1     
  Lines               18301    18296       -5     
  Branches             1685     1685              
==================================================
- Hits                14251    14224      -27     
- Misses               3543     3564      +21     
- Partials              507      508       +1     
Flag Coverage Δ Complexity Δ
gate 90.50% <85.71%> (-0.52%) 0.00 <0.00> (ø)
moove 74.82% <74.07%> (-0.42%) 1635.00 <34.00> (-18.00)
ui 79.91% <100.00%> (+<0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...oove/commons/exceptions/NotFoundExceptionLegacy.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...cd/moove/legacy/moove/service/UserServiceLegacy.kt 79.41% <0.00%> (-20.59%) 14.00 <0.00> (ø)
ui/src/modules/Main/Sidebar/styled.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
...rc/modules/Tokens/Comparation/Modal/Regenerate.tsx 100.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Tokens/Comparation/Modal/Revoke.tsx 66.66% <ø> (ø) 0.00 <0.00> (ø)
...ernal/use_case/system_token/create_system_token.go 94.59% <50.00%> (-5.41%) 0.00 <0.00> (ø)
.../charlescd/moove/application/SystemTokenService.kt 50.00% <50.00%> (ø) 2.00 <2.00> (?)
...escd/moove/security/filter/RateLimitInterceptor.kt 90.90% <50.00%> (-9.10%) 5.00 <0.00> (ø)
...tlin/io/charlescd/moove/application/UserService.kt 87.50% <57.14%> (-12.50%) 17.00 <5.00> (+4.00) ⬇️
gate/internal/domain/system_token.go 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60190c2...aedc3e6. Read the comment docs.

@emiteze emiteze merged commit 84d99dc into system-token Apr 30, 2021
@emiteze emiteze deleted the fixing-permissions-by-workspace-query branch April 30, 2021 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants