Delete deployment config #1136
Delete deployment config #1136
Conversation
Signed-off-by: Mateus Cruz <emiteze@hotmail.com>
Signed-off-by: Mateus Cruz <emiteze@hotmail.com>
| WHERE id = ? | ||
| """ | ||
|
|
||
| this.jdbcTemplate.update(statement, id) |
There was a problem hiding this comment.
Is this method safe against sqlinjection?
There was a problem hiding this comment.
JdbcTemplate handles itself the majority of sql injection cases... we never had to deal with some case specifically
There was a problem hiding this comment.
Since jdbcTemplate probably uses preparedStatement under the hood I personally don't think it's kinda a problem
Signed-off-by: Mateus Cruz <emiteze@hotmail.com>
emiteze
dismissed stale reviews from angelicalimazup and lucasbfernandes
via
28ae301
Codecov Report
@@ Coverage Diff @@
## main #1136 +/- ##
=========================================
Coverage 77.01% 77.01%
- Complexity 2179 2182 +3
=========================================
Files 1234 1235 +1
Lines 17805 17810 +5
Branches 1618 1618
=========================================
+ Hits 13713 13717 +4
- Misses 3610 3611 +1
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Issue Description
Today we can't delete deployment configuration, only disassociate from workspace.
Solution
Implement the delete endpoint that would effectively delete the configuration