Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Remove unnecessary id from log response #1137

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Conversation

leandrorodrigueszup
Copy link
Contributor

O id no LogResponse não é mais necessario. Foi removido.

Signed-off-by: Leandro Rodrigues <leandro.rodrigues@zup.com.br>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label Apr 30, 2021
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1137 (cfeb755) into main (80e0db0) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1137      +/-   ##
============================================
+ Coverage     76.79%   77.02%   +0.23%     
  Complexity     2182     2182              
============================================
  Files          1245     1235      -10     
  Lines         17984    17809     -175     
  Branches       1637     1618      -19     
============================================
- Hits          13810    13717      -93     
+ Misses         3691     3610      -81     
+ Partials        483      482       -1     
Flag Coverage Δ Complexity Δ
moove 75.54% <ø> (+0.01%) 1663.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...rastructure/service/client/response/LogResponse.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
ui/src/modules/Modules/Comparation/View/index.tsx 41.66% <0.00%> (-45.00%) 0.00% <0.00%> (ø%)
ui/src/modules/Metrics/Deploys/CircleFilter.tsx 80.00% <0.00%> (-20.00%) 0.00% <0.00%> (ø%)
ui/src/modules/Circles/Release/Create/helpers.ts 69.23% <0.00%> (-6.77%) 0.00% <0.00%> (ø%)
ui/src/modules/Circles/Release/Create/index.tsx 66.66% <0.00%> (-5.56%) 0.00% <0.00%> (ø%)
ui/src/modules/Main/Sidebar/MenuItems/index.tsx 94.73% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
ui/src/core/providers/modules.ts 72.72% <0.00%> (-4.55%) 0.00% <0.00%> (ø%)
...ettings/Credentials/Sections/MetricAction/Form.tsx 84.84% <0.00%> (-2.34%) 0.00% <0.00%> (ø%)
ui/src/modules/Modules/hooks/component.ts 71.42% <0.00%> (-2.11%) 0.00% <0.00%> (ø%)
...ings/Credentials/Sections/MetricProvider/styled.ts 88.88% <0.00%> (-2.03%) 0.00% <0.00%> (ø%)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e0db0...cfeb755. Read the comment docs.

Copy link

@fandrade-zup fandrade-zup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fandrade-zup fandrade-zup merged commit 84f843a into main Apr 30, 2021
@fandrade-zup fandrade-zup deleted the logs-remove-id-response branch April 30, 2021 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants