Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fixing system token test that broke by deployment logs service update #1138

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

emiteze
Copy link
Contributor

@emiteze emiteze commented Apr 30, 2021

No description provided.

Signed-off-by: Mateus Cruz <emiteze@hotmail.com>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label Apr 30, 2021
@emiteze emiteze changed the title Fixing system token test that broked by deployment logs service update Fixing system token test that broke by deployment logs service update Apr 30, 2021
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1138 (fedcc4a) into main (dd27e18) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1138      +/-   ##
============================================
- Coverage     76.92%   76.78%   -0.14%     
+ Complexity     2182     2164      -18     
============================================
  Files          1255     1255              
  Lines         18162    18143      -19     
  Branches       1637     1637              
============================================
- Hits          13972    13932      -40     
- Misses         3699     3720      +21     
  Partials        491      491              
Flag Coverage Δ Complexity Δ
moove 75.12% <ø> (-0.43%) 1645.00 <ø> (-18.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...n/io/charlescd/moove/security/utils/FilterUtils.kt 27.77% <0.00%> (-50.01%) 3.00% <0.00%> (-10.00%)
...cd/moove/legacy/moove/service/UserServiceLegacy.kt 79.41% <0.00%> (-20.59%) 14.00% <0.00%> (ø%)
...tlin/io/charlescd/moove/application/UserService.kt 87.50% <0.00%> (-12.50%) 17.00% <0.00%> (+4.00%) ⬇️
...escd/moove/security/filter/RateLimitInterceptor.kt 90.90% <0.00%> (-9.10%) 5.00% <0.00%> (ø%)
...pplication/workspace/response/WorkspaceResponse.kt 85.52% <0.00%> (-0.97%) 10.00% <0.00%> (ø%)
...n/io/charlescd/moove/application/WebhookService.kt 100.00% <0.00%> (ø) 5.00% <0.00%> (-1.00%)
...cy/moove/service/CredentialConfigurationService.kt 89.92% <0.00%> (ø) 32.00% <0.00%> (ø%)
.../deployment/impl/CreateDeploymentInteractorImpl.kt 96.96% <0.00%> (ø) 11.00% <0.00%> (ø%)
...ve/controller/CredentialConfigurationController.kt 100.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
...ok/impl/CreateWebhookSubscriptionInteractorImpl.kt 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd27e18...fedcc4a. Read the comment docs.

@angelicalimazup angelicalimazup merged commit 34cc455 into main Apr 30, 2021
@angelicalimazup angelicalimazup deleted the fix-moove-test branch April 30, 2021 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants